Task #10073: fix checkstyle warnings - Retrascope - Open-Source Projects

Actions

Copy link

Task #10073

closed

fix checkstyle warnings

Added by Sergey Smolov about 4 years ago. Updated 12 months ago.

Status:

Closed

Priority:

High

Assignee:

Maxim Chudnov

Category:

Refactoring

Target version:

1.1

Start date:

01/27/2020

Due date:

% Done:

100%

Estimated time:

Detected in build:

master

Published in build:

1.1.3-beta-230504

Description

$ ./gradlew checkstyleMain checkstyleTest
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :checkstyleTest
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/cfg/printer/c/VhdlCfgPrinterCTestCase.java:14: warning: 'package' should be separated from previous statement.
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/cfg/printer/c/VhdlPrinterCBenchTest.java:14: warning: 'package' should be separated from previous statement.
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/formula/sample/HlddSmvFormulaPrinterVerilogTest.java:36: warning: Line is longer than 100 characters (found 104).
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/parser/verilog/VerilogParserTestCase.java:19: warning: Wrong lexicographical order for 'junitparams.JUnitParamsRunner' import. Should be before 'org.junit.runner.RunWith'.

Actions

Copy link

Updated by Maxim Chudnov about 4 years ago

Status changed from New to Resolved

Actions

Copy link

Updated by Maxim Chudnov about 4 years ago

Status changed from Resolved to New

Actions

Copy link

Updated by Sergey Smolov about 4 years ago

Priority changed from Normal to High

Actions

Copy link

Updated by Maxim Chudnov about 4 years ago

Status changed from New to Resolved

Actions

Copy link

Updated by Sergey Smolov about 4 years ago

Status changed from Resolved to Open

New warnings appear:

$ ./gradlew checkStyle

> Task :checkstyleTest
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/efsm/printer/graphml/VerilogEfsmPrinterGraphMlBenchTest.java:25: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/formula/VerilogHlddFormulaBenchTest.java:27: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/usedef/VerilogHlddUseDefBenchTest.java:24: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/parser/HdlParserBenchTest.java:82: warning: First sentence of Javadoc is incomplete (period is missing) or not present.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/parser/VhdlParserTestSuite.java:572: warning: 'method def modifier' have incorrect indentation level 1, expected level should be 2.
Checkstyle rule violations were found. See the report at: file:///home/ssedai/projects/retrascope/build/reports/checkstyle/test.html
Checkstyle files with violations: 5
Checkstyle violations by severity: [warning:5]

Actions

Copy link