Project

General

Profile

Task #10073

fix checkstyle warnings

Added by Sergey Smolov 8 months ago. Updated 7 months ago.

Status:
Verified
Priority:
High
Assignee:
Category:
Refactoring
Target version:
Start date:
01/27/2020
Due date:
% Done:

100%

Estimated time:
Detected in build:
master
Published in build:

Description

$ ./gradlew checkstyleMain checkstyleTest
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :checkstyleTest
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/cfg/printer/c/VhdlCfgPrinterCTestCase.java:14: warning: 'package' should be separated from previous statement.
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/cfg/printer/c/VhdlPrinterCBenchTest.java:14: warning: 'package' should be separated from previous statement.
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/formula/sample/HlddSmvFormulaPrinterVerilogTest.java:36: warning: Line is longer than 100 characters (found 104).
[ant:checkstyle] retrascope/src/test/java/ru/ispras/retrascope/parser/verilog/VerilogParserTestCase.java:19: warning: Wrong lexicographical order for 'junitparams.JUnitParamsRunner' import. Should be before 'org.junit.runner.RunWith'.

History

#1

Updated by Maxim Chudnov 8 months ago

  • Status changed from New to Resolved
#2

Updated by Maxim Chudnov 8 months ago

  • Status changed from Resolved to New
#3

Updated by Sergey Smolov 7 months ago

  • Priority changed from Normal to High
#4

Updated by Maxim Chudnov 7 months ago

  • Status changed from New to Resolved
#5

Updated by Sergey Smolov 7 months ago

  • Status changed from Resolved to Open

New warnings appear:

$ ./gradlew checkStyle

> Task :checkstyleTest
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/efsm/printer/graphml/VerilogEfsmPrinterGraphMlBenchTest.java:25: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/formula/VerilogHlddFormulaBenchTest.java:27: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/engine/hldd/printer/smv/usedef/VerilogHlddUseDefBenchTest.java:24: warning: Wrong lexicographical order for 'ru.ispras.retrascope.engine.gadd.transformer.efsm.EfsmStatistics' import. Should be before 'ru.ispras.retrascope.engine.gadd.transformer.efsm.GaddEfsmTransformer'.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/parser/HdlParserBenchTest.java:82: warning: First sentence of Javadoc is incomplete (period is missing) or not present.
[ant:checkstyle] /home/ssedai/projects/retrascope/src/test/java/ru/ispras/retrascope/parser/VhdlParserTestSuite.java:572: warning: 'method def modifier' have incorrect indentation level 1, expected level should be 2.
Checkstyle rule violations were found. See the report at: file:///home/ssedai/projects/retrascope/build/reports/checkstyle/test.html
Checkstyle files with violations: 5
Checkstyle violations by severity: [warning:5]

#6

Updated by Maxim Chudnov 7 months ago

  • Status changed from Open to Resolved
#7

Updated by Sergey Smolov 7 months ago

  • % Done changed from 0 to 100
  • Status changed from Resolved to Verified

Also available in: Atom PDF