Project

General

Profile

Actions

Bug #8043

closed

Bridge does not indent properly callback calls if some callback fails and then is called second time

Added by Evgeny Novikov about 7 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
High
Category:
Bridge
Target version:
-
Start date:
03/21/2017
Due date:
% Done:

0%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

I attached an example. Perhaps there are incorrect comments/actions in the error trace.


Files

error-trace.json (181 KB) error-trace.json Evgeny Novikov, 03/21/2017 03:02 PM
2.jpg (27.7 KB) 2.jpg Visualized error trace Vladimir Gratinskiy, 03/21/2017 07:20 PM
Actions #1

Updated by Vladimir Gratinskiy about 7 years ago

  • Status changed from New to Feedback

I didn't find any problems with the attached error trace. Could you explain clearly what's wrong and attach screenshots?

Actions #2

Updated by Evgeny Novikov about 7 years ago

  • Status changed from Feedback to Open

Second call of probe callback isn't indented as the first one. But this should be the case. Perhaps the issue is with actions but also there can be issues during visualization.

Actions #3

Updated by Evgeny Novikov about 7 years ago

I think that Ilja should comment whether we need to put both probe callbacks under the same action comment or they should be split. Ideally there should be some extra comment showing that the first probe callback fails.

Actions #4

Updated by Vladimir Gratinskiy about 7 years ago

It's how error trace looks for me (the newest master). The same indent for both callback actions.

Actions #5

Updated by Evgeny Novikov about 7 years ago

Vladimir Gratinskiy wrote:

It's how error trace looks for me (the newest master). The same indent for both callback actions.

The mm_pci_probe callback is indented differently although it is obviously the same entity. Let's wait for Ilja will see this and think how to do the best. Perhaps some more actions will be introduced to make things.

Actions #6

Updated by Vladimir Gratinskiy over 4 years ago

  • Status changed from Open to Feedback

Is that problem still relevant for the klever-3.0 with new error trace format?

Actions #7

Updated by Evgeny Novikov over 4 years ago

  • Status changed from Feedback to Rejected

Now the issue is not relevant.

Actions

Also available in: Atom PDF